Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RestFixer for the model has Skin which non-inverse-global-rest #65278

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix RestFixer for the model has Skin which non-inverse-global-rest #65278

merged 1 commit into from
Sep 5, 2022

Conversation

TokageItLab
Copy link
Member

Previously, RestFixer forced Skin to re-bind to non-inverse-global-rest and did not take into account the original bound Pose.

This PR takes the original bound Pose into account in the re-binding calculations.

Before (broken):
image

After:
image

Test model
Siren Head Monkey Run / CC by The Pre Alpha Man
https://sketchfab.com/3d-models/siren-head-monkey-run-2654e635af28463f86f71f9720b914e6

@TokageItLab TokageItLab added this to the 4.0 milestone Sep 3, 2022
@TokageItLab TokageItLab requested a review from a team as a code owner September 3, 2022 07:14
@TokageItLab
Copy link
Member Author

Replaced some checks with ERR_CONTINUE macro and reduced nesting.

@fire fire requested a review from a team September 3, 2022 16:07
@fire
Copy link
Member

fire commented Sep 4, 2022

I plan to try a few more models and report back.

fire
fire approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the siren head gltf bind bug.

@fire
Copy link
Member

fire commented Sep 4, 2022

ANIM_siren.zip

Tested the whole retargeting workflow.

Screenshot 2022-09-04 135158

Screenshot 2022-09-04 135141

@akien-mga akien-mga merged commit b71a7fa into godotengine:master Sep 5, 2022
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the fix-node-transform-skin branch September 16, 2022 21:02
@TokageItLab TokageItLab mentioned this pull request Apr 26, 2023
Closed
@TokageItLab TokageItLab mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:import topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TokageItLab @fire @akien-mga